Skip to content

[Infra] Add --legacy flag to xcresulttool#14717

Merged
andrewheard merged 4 commits intomainfrom
ah/combine-xcresultool
Apr 15, 2025
Merged

[Infra] Add --legacy flag to xcresulttool#14717
andrewheard merged 4 commits intomainfrom
ah/combine-xcresultool

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 15, 2025

Added --legacy to the invocation of xcresulttool to temporarily fix the following error:

xcrun xcresulttool get --path /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseCombineSwift-gkzikpntrmtrlteyoawsixkbxldq/Logs/Test/Test-FirebaseCombineSwift-Unit-integration-2025.04.15_07-24-19-+0000.xcresult --format json
Error: This command is deprecated and will be removed in a future release, --legacy flag is required to use it.
Usage: xcresulttool get object [--legacy] --path <path> [--id <id>] [--version <version>] [--format <format>]
  See 'xcresulttool get object --help' for more information.

Note: We'll need to find an alternative eventually since "command is deprecated and will be removed in a future release".

(cherry picked from commit 9b63014)

#no-changelog

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Apr 15, 2025

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard mentioned this pull request Apr 15, 2025
Closed
@andrewheard andrewheard requested review from ncooke3 and paulb777 April 15, 2025 15:12
@andrewheard andrewheard merged commit 8a61286 into main Apr 15, 2025
35 checks passed
@andrewheard andrewheard deleted the ah/combine-xcresultool branch April 15, 2025 16:26
@ncooke3
Copy link
Member

ncooke3 commented Apr 16, 2025

Not sure how this isn't fixing the combine workflow: https://github.com/firebase/firebase-ios-sdk/actions/runs/14486724441/workflow

@andrewheard andrewheard mentioned this pull request Apr 17, 2025
Merged
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewheard @ncooke3 @paulb777 @morganchen12